feat(component): Create new component for feature information in quick start guides#16855
feat(component): Create new component for feature information in quick start guides#16855inventarSarah merged 23 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…ick-start/clean-up-includes
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Wrong type prop shows descriptions instead of navigation
- Updated the Bun/Cloudflare/Deno/WASM PlatformSection to use type="findInSentry" so it now renders navigation instructions like the other sections.
Or push these changes by commenting:
@cursor push 9100a8fda8
Preview (9100a8fda8)
diff --git a/includes/quick-start-locate-data-expandable.mdx b/includes/quick-start-locate-data-expandable.mdx
--- a/includes/quick-start-locate-data-expandable.mdx
+++ b/includes/quick-start-locate-data-expandable.mdx
@@ -37,7 +37,7 @@
<PlatformSection supported={["javascript.bun", "javascript.cloudflare", "javascript.deno", "javascript.wasm"]}>
-<FeatureInfo features={["issues", "logs", "tracing"]} type="learnMore" />
+<FeatureInfo features={["issues", "logs", "tracing"]} type="findInSentry" />
</ PlatformSection>This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
…ick-start/clean-up-includes
…try/sentry-docs into smi/quick-start/clean-up-includes
chargome
left a comment
There was a problem hiding this comment.
Thanks for simplifying! Generally this would be easier to review if you split it up a bit, but we can keep as is. Left some comments 🚀
| type FeatureKey = | ||
| | 'issues' | ||
| | 'tracing' | ||
| | 'sessionReplay' | ||
| | 'logs' | ||
| | 'profiling' | ||
| | 'userFeedback'; |
There was a problem hiding this comment.
Added "Metrics" to the component including the needed content
| type="learnMore" | ||
| /> | ||
|
|
||
| </ PlatformSection> |
There was a problem hiding this comment.
nit: Doesn't the formatter require </PlatformSection>? 🤔
There was a problem hiding this comment.
🤔nothing complained to me about the spaces. Thanks for pointing this out -- removed the spaces
| /> | ||
|
|
||
| <PlatformContent includePath="getting-started-features-expandable" /> | ||
| <Include name="quick-start-features-expandable" /> |
There was a problem hiding this comment.
| <Include name="quick-start-features-expandable" /> | |
| <Include name="quick-start-features-expandable-cloudflare-frameworks" /> |
There was a problem hiding this comment.
I might be wrong here, would this add frontend only features?
There was a problem hiding this comment.
This gets the default Cloudflare version of the include, which contains the same features as Hono on Cloudflare.
| <FeatureInfo | ||
| features={[ | ||
| "issues", | ||
| "logs", | ||
| "sessionReplay", | ||
| "tracing", | ||
| "profiling", | ||
| "userFeedback", | ||
| ]} |
There was a problem hiding this comment.
m: I think that cursor is right here with the order of features, tracing should be after issues
There was a problem hiding this comment.
Updated the order accordingly.
I would then also update the order of the onboarding/feature options (in a separate issue) because there we always have Issues > Logs > session Replay > Tracing > Profiling > User Feedback
What do you think?
| </ExternalLink>{' '} | ||
| page and select a trace to reveal more information about each span, its duration, | ||
| and any errors. For an interactive UI walkthrough, click{' '} | ||
| <a href="/product/sentry-basics/distributed-tracing/generate-first-error/#ui-walkthrough"> |
There was a problem hiding this comment.
I tried to use but ran into server/client component issues that I couldn't resolve.
Happy to revisit this, but I need dev support 🙏
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Autofix Details
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Profiling external link URL likely broken
- Updated the profiling find-in-Sentry link to the orgredirect URL pattern used by existing profiling documentation.
- ✅ Fixed: Locate-data content changes from ordered to unordered list
- FeatureInfo now renders find-in-Sentry content in an ordered list while keeping learn-more content unordered.
Or push these changes by commenting:
@cursor push 4d82d94864
Preview (4d82d94864)
diff --git a/src/components/featureInfo.tsx b/src/components/featureInfo.tsx
--- a/src/components/featureInfo.tsx
+++ b/src/components/featureInfo.tsx
@@ -102,7 +102,7 @@
findInSentry: (
<Fragment>
Open the{' '}
- <ExternalLink href="https://sentry.io/profiling">
+ <ExternalLink href="https://sentry.io/orgredirect/organizations/:orgslug/profiling">
<strong>Profiles</strong>
</ExternalLink>{' '}
page, select a transaction, and then a profile ID to view its flame graph. For
@@ -158,8 +158,10 @@
* @param type - learnMore shows feature descriptions, findInSentry shows navigation help
*/
export function FeatureInfo({features, type}: FeatureInfoProps) {
+ const ListTag = type === 'findInSentry' ? 'ol' : 'ul';
+
return (
- <ul>
+ <ListTag>
{features.map(key => {
const feature = FEATURE_DATA[key];
@@ -176,6 +178,6 @@
return <li key={key}>{feature.findInSentry}</li>;
})}
- </ul>
+ </ListTag>
);
}This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
…try/sentry-docs into smi/quick-start/clean-up-includes
chargome
left a comment
There was a problem hiding this comment.
LGTM but please check the failing 404 linter too
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| | 'logs' | ||
| | 'profiling' | ||
| | 'userFeedback' | ||
| | 'metrics'; |
There was a problem hiding this comment.
Unused metrics feature defined but never referenced
Low Severity
The metrics key is defined in the FeatureKey type and has a full data entry in FEATURE_DATA, but it's never referenced in any of the four new include files (quick-start-features-expandable.mdx, quick-start-locate-data-expandable.mdx, and their cloudflare-frameworks variants). This is dead code that adds maintenance burden without being used anywhere in the codebase.
Additional Locations (1)
| visualize log data to understand what's happening in your applications. | ||
|
|
||
| </Expandable> | ||
| <Include name="quick-start-features-expandable" /> |
There was a problem hiding this comment.
Orphaned passthrough files no longer referenced anywhere
Low Severity
The _default.mdx file in getting-started-features-expandable and javascript.mdx in getting-started-verify-locate-data were converted to passthroughs but are no longer referenced by any file. All callers were migrated to use <Include> directly, so these platform-include files are now dead code that could be deleted along with their parent directories.
Additional Locations (1)
…k start guides (#16855) <!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR **Background**: In our quick start guides, we have two Expandables that explain Sentry features: - "Do you want to learn more about these features?" - "Need help locating the captured errors in your Sentry project?" I created these as PlatformIncludes, which led to: - inconsistency because listed features didn't always match the actual onboarding options - multiple files containing the same content - updating feature descriptions or adding a new feature required editing multiple files **Changes:** Created a new component that - centralizes feature descriptions in one file - supports "learn more" and "find in Sentry" content types - works across languages and platforms (it is not JS-specific) - makes it easier to add new features or update descriptions/links etc I updated all the quick start guides to use the new include & component and removed the old PlatformInclude files. closes: #16320 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>



DESCRIBE YOUR PR
Background:
In our quick start guides, we have two Expandables that explain Sentry features:
I created these as PlatformIncludes, which led to:
Changes:
Created a new component that
I updated all the quick start guides to use the new include & component and removed the old PlatformInclude files.
closes: #16320
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES